[fpc-devel] Patch for fixing CE compilation

[Marc Weustink]

Oro06 wrote:
> Marc Weustink wrote:
>> Hi,
>>   
> hi,
>> This patch fixes CE compilation.
>> I would have applied it myself, but I've some questions about the common
>> win dir and the wince implementation in the rtl.
>>   
> you can apply it

OK, I'll do.

Another question left for the other win devels:

 >> Further, not related to this fix, but just noticed it, I commented
 >> the declatarion of WCHAR in both base.inc.
 >> AFAICS, WCHAR is defined in systemh and IMO there is no reason to
 >> define it elsewhere again. I guess more cases are present.
 >> Is there a reason for this (other than a leftover form the past) ?

is it OK to remove the extra declarations ?


[snip]

>> At the same time I wondered why there are 2 declarations. Why isn't
>> wince ising the win definition as well ?
> 
>> Same counts for instance for socket.pp, why are there 2 ?
>>   
> from ealry stage of arm/wince port api fork was decided moslty for 2 
> reasons :
> 1- not polluting win32 api with too much ifdefs

I already thought so. IIRC, at that time there was only win32 (and no win)

> 2- wince sysgen is not the same for wince and win32 (so even for ms it's 
> forked)
> 
> now , after one year feedback
> the fact is that there not so much differences (few consts and records, 
> calling convention)
> so maybe some cleaning could be done in that way
> arm/wince compiler is now running very well, i guess a priorised todo  
> for next release could be done :)

OK


Marc